Storage: Define per-pool default block size #14594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Dec 6, 2024
lxd/scriptlet/instance_placement.go
Outdated
| @@ -221,7 +221,12 @@ func InstancePlacementRun(ctx context.Context, l logger.Logger, s *state.State, | |||
|
|
|||
| // Apply VM root disk size defaults if not specified. | |||
| if req.Type == api.InstanceTypeVM && rootDiskSizeStr == "" { | |||
| rootDiskSizeStr = storageDrivers.DefaultBlockSize | |||
| driver, err := storageDrivers.Load(s, rootDiskConfig["pool"], "", nil, nil, nil, nil) | |||
There was a problem hiding this comment.
please can you add a function like storageDrivers.DefaultVMBlockFilesystemSize for this.
There was a problem hiding this comment.
I added a function under storage/util that helps with this, I hope this is along the lines of what you expected.
If so, this is ready for a review.
hamistao
force-pushed
the
pool_default_block_sizes
branch
from
b9e7305 to
f14e1a9
Compare
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
All drivers share a common default block size value with the exception of PowerFlex. Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Created in the `storage` package to make use of `LoadByName` can't use it on `storage/drivers` because of import cycle. Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
…ported This is aligned with the behavior of the other drivers. Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
pool_default_block_sizes
branch
from
f14e1a9 to
0aff592
Compare
tomponline
reviewed
Dec 9, 2024
tomponline
reviewed
Dec 9, 2024
tomponline
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some improvements that were originally a part of the fix implemented in #14511, but ended up not being needed for that fix. They are still nice to have and thus were included here.