(#3729) only DRM_MODE_CONNECTED outputs can be added to the output list #3747
+120
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkae
changed the title
mattkae
changed the title
|
I will add tests once we are happy with this implementation. |
AlanGriffiths
requested changes
Feb 7, 2025
| @@ -14,10 +14,12 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| #define MIR_LOG_COMPONENT "gbm-kms" | |||
There was a problem hiding this comment.
There should be no need for this: MIR_LOG_COMPONENT_FALLBACK="gbm-kms" is in CMakeLists.txt
| @@ -55,6 +57,12 @@ void mgg::RealKMSOutputContainer::update_from_hardware_state() | |||
| drm_fd == candidate->drm_fd(); | |||
| }); | |||
|
|
|||
| if (connector->connection != DRM_MODE_CONNECTED) | |||
| { | |||
| mir::log_warning("Connector is not connected, so not adding this output to the list."); | |||
There was a problem hiding this comment.
I think this is "info" at best (nothing is wrong), and probably not useful at all without some way to identify which output.
|
Oh, and do run |
|
Maybe this isn't the best of ways to do this... Perhaps we still add the connector, but we don't use the output. |
|
This is wrong. The tests proved this to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3729
According to the documentation for
drmModeConnection:With this mind, it does not make sense for us to create a
DisplaySinkfor outputs that are not connected, since these do not have display sinks.How to test