Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the lifetime of the accessibility manager to keep enable-key-repeat #3749

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Extend the lifetime of the accessibility manager to keep enable-key-repeat #3749

merged 2 commits into from
Feb 12, 2025

Conversation

tarek-y-ismail
Copy link
Contributor

closes #3743

@tarek-y-ismail
Ensure config mutex is default initialized before its used
cdde031
@tarek-y-ismail
Extend the lifetime of the accessibility manager to keep
02c6bbc 
enable-key-repeat

Instead of creating a "temporary" accessibility manager which gets
immediately deallocated after the line is executed, we store and pass
the shared pointer to the wayland connector, extending the lifetime of
the accessibility manager enough to not lose the value of
`enable-key-repeat`
@tarek-y-ismail tarek-y-ismail self-assigned this Feb 10, 2025
@tarek-y-ismail tarek-y-ismail requested a review from a team as a code owner February 10, 2025 11:07
@tarek-y-ismail tarek-y-ismail mentioned this pull request Feb 12, 2025
Open
AlanGriffiths
AlanGriffiths approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlanGriffiths
Copy link
Collaborator

Hmm, the TestConfigFile.with_no_reloading_when_a_file_is_written_nothing_is_loaded ... Segmentation fault failure looks suspicious

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@tarek-y-ismail tarek-y-ismail added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit fefa789 Feb 12, 2025
22 of 28 checks passed
@tarek-y-ismail tarek-y-ismail deleted the enable-key-repeat-option-is-lost branch February 12, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@mattkae mattkae Awaiting requested review from mattkae

Assignees

@tarek-y-ismail tarek-y-ismail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable-key-repeat gets lost during initialization
2 participants
@tarek-y-ismail @AlanGriffiths