Automatic gui version #3806
Open
Automatic gui version #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricab
reviewed
Dec 3, 2024
src/client/gui/CMakeLists.txt.linux
Outdated
| @@ -29,7 +29,7 @@ set(MULTIPASS_GUI_EXECUTABLE_FULL_PATH ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${MULTI | |||
|
|
|||
| file(GLOB_RECURSE MULTIPASS_GUI_SOURCE_FILES ${MULTIPASS_GUI_SOURCE_DIR}/lib/*.dart) | |||
|
|
|||
| set(FLUTTER_BUILD_ARGS --release --suppress-analytics --verbose) | |||
| set(FLUTTER_BUILD_ARGS --release --suppress-analytics --verbose --build-name=${MULTIPASS_VERSION}) | |||
There was a problem hiding this comment.
Shouldn't we split between build name and number?
There was a problem hiding this comment.
Ah, yes we should!
There was a problem hiding this comment.
Since the --build-number can only contain digits, I made it so that only the digits are extracted from the version string. So from 1.15.0-..., all the digits are extracted. If there are none, it defaults to 0. This already happens by default on macOS, so I made it the same on all platforms.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 256 256
Lines 14584 14584
=======================================
Hits 12972 12972
Misses 1612 1612 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
automatic-gui-version
branch
from
2527d75
to
5732634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the GUI version using the --build-name and --build-number args, using the MULTIPASS_VERSION CMake var. This way, we don't have to manually update the version all the time.
For the --build-number, the argument must only contain digits, so we extract the digits out of the commit hash respective to the current version.