Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add daemon gRPC boilerplate for AZs #3922

Open
wants to merge 1 commit into
base: availability-zones
Choose a base branch
from

Conversation

andrei-toterman
Copy link
Contributor

This PR adds AZ information to RPC messages that need it, as well as methods for listing AZs and changing their state.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 88.98%. Comparing base (aaafd0d) to head (988db19).

Files with missing lines Patch % Lines
src/daemon/daemon.cpp 14.28% 12 Missing ⚠️
src/daemon/daemon_rpc.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           availability-zones    #3922      +/-   ##
======================================================
- Coverage               89.11%   88.98%   -0.14%     
======================================================
  Files                     255      255              
  Lines                   14603    14627      +24     
======================================================
+ Hits                    13014    13016       +2     
- Misses                   1589     1611      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants