Modified the 3rd party compilation order #3939
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sploder12
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Thank you for your interest and contribution @ljonathan0719! Unfortunately, there are some issues preventing building.
Also, would you mind signing the CLA using the same GitHub handle / same email?
Comment on lines
+135
to
+136
| add_subdirectory(3rd-party/grpc) | ||
| add_subdirectory(3rd-party/poco) |
There was a problem hiding this comment.
grpc and poco are part of vcpkg so cmake won't be able to add them like this.
|
|
||
| # gRPC config | ||
| find_package(gRPC CONFIG REQUIRED) | ||
|
|
||
| # Ensure custom libraries are built first | ||
| add_subdirectory(3rd-party/libssh) |
There was a problem hiding this comment.
cmake has issues here since libssh is also added by 3rd-party/CMakeLists.txt (invoked by add_subdirectory(3rd-party)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #3802 where manually building Multipass fails due to OpenSSL header detection errors in libssh. The issue was caused due to an incorrect dependency order in the CMakeLists.txt file. This resulted in the system's OpenSSL installation verison being used instead of the custom built 3rd party libraries.