fix: DPE-6485 optional restart on instance configuration #607
+55
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
carlcsaposs-canonical,
shayancanonical,
sinclert-canonical and
taurus-forever
shayancanonical
approved these changes
Feb 4, 2025
sinclert-canonical
approved these changes
Feb 5, 2025
| logger.info("Recovering unit") | ||
| if self.app.planned_units() == 1: | ||
| self._mysql.reboot_from_complete_outage() | ||
| else: |
There was a problem hiding this comment.
A small improvement to reduce indentation levels here would be to add a return clause within the if statement, and leave everything within the else block un-indented.
taurus-forever
approved these changes
Feb 6, 2025
| @@ -1955,6 +1961,7 @@ def is_instance_in_cluster(self, unit_label: str) -> bool: | |||
| user=self.server_config_user, | |||
| password=self.server_config_password, | |||
| host=self.instance_def(self.server_config_user), | |||
| exception_as_warning=True, | |||
There was a problem hiding this comment.
Can you please share some explanation here? Tnx!
There was a problem hiding this comment.
When the method is called on an instance that does not belong to the cluster (initialization, some self healing cases), it throws an noisy error log which is not a failure per se, but a valid output.
…re/optional-restart-on-configure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Instance configuration need to expose
restartfor explicit restart under pebble.Solution
restart