[MISC] Refresh all charm libs #608
Merged
+1,004
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
requested review from
paulomach,
shayancanonical and
carlcsaposs-canonical
can you open a separate issue/thread so that discussion is separate from the changes in this PR? 2 cents: libs should not be a ci check. Instead, have something closer to renovate where we get prs to auto update libs. I think if we invest in changing things, we should invest in that direction. But also libs seem to be going away because of issues with pydeps, so not sure if it's worth investing |
carlcsaposs-canonical
approved these changes
Feb 6, 2025
paulomach
approved these changes
Feb 6, 2025
sinclert-canonical
force-pushed
the
sinclert/charm-libs
branch
from
aada4e1 to
14ec05d
Compare
sinclert-canonical
force-pushed
the
sinclert/charm-libs
branch
from
14ec05d to
0be79d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refreshes all charm libs that have fallen out-of-date.
Discussion
Given my experience contributing to MySQL repositories so far, it seems that folks are OK merging PRs with the
Check libsCI job failing. I wonder whether a more flexible approach to having charm libs out of date would be better.I would like to propose to extract the check to a new workflow file + remove these lines, making the
Check libsCI job behave as the original authors designed it by default, tagging the PR with the Libraries out of sync label (similarly to what the PostgreSQL repositories do).Opinions?