Replace MinIO with S3 Integrator #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Mar 10, 2025
MichaelThamm
approved these changes
Mar 11, 2025
lucabello
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves COS terraform modules by deprecating the use of MinIO variables as an object storage in favour of only using
s3-integratorcharm variables.Now
loki,mimirandtempomodules receives as an arguments3_user,s3_password,s3_endpointand[loki|mimir|tempo]_bucketso they can use these values to configures3-integratorcharms.Related to issue #247
How to test it.
Just follow the instructions in the documentation post: https://discourse.charmhub.io/t/how-to-deploy-cos-in-a-distributed-with-terraform/15878