Remove BUILTIN_TESTLISTS to simplify things #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelallan72
requested review from
a team,
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
samuelallan72
force-pushed
the
simplify-testlists
branch
from
6c03940 to
90c1f24
Compare
samuelallan72
force-pushed
the
simplify-testlists
branch
from
90c1f24 to
1cb6dbd
Compare
samuelallan72
commented
Jan 19, 2024
| fi | ||
|
|
||
| cp -r $SNAP/tempest_test_lists/* $SNAP_DATA/tempest_test_lists |
There was a problem hiding this comment.
Why is this copying happening in the first place btw?
|
Let's put this on hold until we figure our whether we really want to change the logic. Moving the PR to WIP for now. |
samuelallan72
force-pushed
the
simplify-testlists
branch
from
1cb6dbd to
11c8acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test lists are already in a well defined directory provided by snap, so we can document them instead.
This both improves the user experience because command line completion can be used for the test list paths,
and makes the code more maintainable by simplifying the logic.
Also change the path to the test lists to be more convenient to type.
Fixes #12
Fixes #62