Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BUILTIN_TESTLISTS to simplify things #75

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ application that automatically generates a tempest configuration appropriate for

The tempest snap can be installed directly from the snap store:

sudo snap install [install-OPTIONS] tempest
sudo snap install [INSTALL-OPTIONS] tempest

## Compatibility matrix

Expand Down Expand Up @@ -101,28 +101,31 @@ tempest run --smoke
For more information please refer to the [Tempest QuickStart] and [python-tempestconf] documentation.

## Test Lists
The tempest snap provides a set of pre-defined test lists with different profiles
and a mechanism to specify them easily.
The tempest snap bundles a set of pre-defined test lists.
They can be found at `/snap/tempest/current/lists/`.

The `@BUILTIN_TESTLISTS` keyword will be automatically replaced by the full path
of the directory storing the built-in test lists.
```
$ ls /snap/tempest/current/lists/
readonly-quick refstack-2022.11

**Note**: the single-quotation marks around the test list file path is required
if the `@BUILTIN_TESTLISTS` keyword is used (in other words, when running tempest
with a built-in test list file). Failure to do so will result in a wrong path
error.
$ tempest run --load-list /snap/tempest/current/lists/readonly-quick
```

### readonly-quick
For quickly verifying the behavior of the target cloud and making sure tempest
is correctly set up
is correctly set up.

tempest run --load-list '@BUILTIN_TESTLISTS/readonly-quick'
```
tempest run --load-list /snap/tempest/current/lists/readonly-quick
```

### refstack-2022.11
Version 2022.11 of the [RefStack] guidelines.
The list includes the required and advisory tests of all platforms.

tempest run --load-list '@BUILTIN_TESTLISTS/refstack-2022.11'
```
tempest run --load-list /snap/tempest/current/lists/refstack-2022.11
```

[OpenStack Antelope release notes - Tempest plugins]: https://releases.openstack.org/antelope/index.html#tempest-plugins
[Tempest release notes]: https://docs.openstack.org/releasenotes/tempest/unreleased.html
Expand Down
6 changes: 3 additions & 3 deletions snap/hooks/install
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/sh -e

if [ ! -d "${SNAP_DATA}/tempest_test_lists" ]; then
mkdir $SNAP_DATA/tempest_test_lists
if [ ! -d "${SNAP_DATA}/lists" ]; then
mkdir $SNAP_DATA/lists
fi

cp -r $SNAP/tempest_test_lists/* $SNAP_DATA/tempest_test_lists
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this copying happening in the first place btw?

cp -r $SNAP/lists/* $SNAP_DATA/lists
6 changes: 3 additions & 3 deletions snap/hooks/post-refresh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/sh -e

if [ ! -d "${SNAP_DATA}/tempest_test_lists" ]; then
mkdir $SNAP_DATA/tempest_test_lists
if [ ! -d "${SNAP_DATA}/lists" ]; then
mkdir $SNAP_DATA/lists
fi

cp -r $SNAP/tempest_test_lists/* $SNAP_DATA/tempest_test_lists
cp -r $SNAP/lists/* $SNAP_DATA/lists
8 changes: 0 additions & 8 deletions snap/local/tempest-wrapper

This file was deleted.

10 changes: 1 addition & 9 deletions snap/snapcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,14 @@ license: Apache-2.0
confinement: strict
grade: stable
base: core22
assumes:
- command-chain
apps:
tempest:
command: bin/tempest
command-chain:
- bin/tempest-wrapper
completer: usr/share/bash-completion/completions/tempest
plugs:
- network-observe
- network
- home
environment:
TESTS: $SNAP_DATA/tempest_test_lists
discover:
command: bin/discover-tempest-config
environment:
Expand All @@ -32,12 +26,10 @@ apps:
- home
- network
parts:
wrapper:
testlists:
plugin: dump
source: ./snap/local
source-type: local
organize:
tempest-wrapper: bin/tempest-wrapper
tempest:
plugin: python
source: https://opendev.org/openstack/tempest.git
Expand Down
Loading