-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use upstreamed parts of craft-application #5239
base: main
Are you sure you want to change the base?
Conversation
affe7a0
to
4af108f
Compare
I triggered a run for the remote build spread tests: https://github.com/canonical/snapcraft/actions/runs/13205639741 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up for early testing. Overall, everything is working well. I found a few things that need to be addressed in craft-application:
-
--project
is failing because this needs to be called before this. -
remote-build: add "Pending" as a possible status output #4956 should be upstreamed. It can be out-of-scope of this task, but we should land it prior to this refactor making its way into a Snapcraft release.
-
Using the craft-application args makes the help messages look less cohesive. Some begin with a capital letter, others don't:
Options:
-h, --help: Show this help message and exit
-v, --verbose: Show debug information and be
more verbose
-q, --quiet: Only show warnings and errors,
not progress
--verbosity: Set the verbosity level to
'quiet', 'brief', 'verbose',
'debug' or 'trace'
-V, --version: Show the application version and
exit
--recover: recover an interrupted build
--launchpad-accept-public-upload: acknowledge that uploaded code
will be publicly available.
--launchpad-timeout: Time in seconds to wait for
launchpad to build.
--project: upload to the specified Launchpad
project
--build-for: Comma-separated list of
architectures to build for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind making this change to the overview?
https://github.com/canonical/craft-application/pull/623/files
The remote-build tests were old and inconsistent. This PR modernizes it by deleting what is handled by craft-application now and reworking the fixtures on the tests that remain for clarity.
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)