Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add optional fallback to /etc/initrd-release #15036

Merged

Conversation

bboozzoo
Copy link
Contributor

@bboozzoo bboozzoo commented Feb 6, 2025

Add /etc/initrd-release documented in os-release(5) as an optional fallback, for cases when the initrd lacks required symlinks.

Cherry picked from #15030

Add /etc/initrd-release documented in os-release(5) as an optional
fallback, for cases when the initrd lacks required symlinks.

Signed-off-by: Maciej Borzecki <[email protected]>
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0a0578b). Learn more about missing BASE report.
Report is 185 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15036   +/-   ##
=========================================
  Coverage          ?   78.23%           
=========================================
  Files             ?     1161           
  Lines             ?   154326           
  Branches          ?        0           
=========================================
  Hits              ?   120738           
  Misses            ?    26154           
  Partials          ?     7434           
Flag Coverage Δ
unittests 78.23% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 6, 2025

Thu Feb 6 17:20:45 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13177507791

Failures:

Preparing:

  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • google-arm:ubuntu-core-22-arm-64

Executing:

  • openstack:centos-9-64:tests/main/degraded
  • openstack:debian-12-64:tests/main/microk8s-smoke:edge
  • openstack:debian-sid-64:tests/main/microk8s-smoke:edge
  • openstack:fedora-40-64:tests/main/degraded
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional

Restoring:

  • openstack:fedora-40-64:tests/main/revert:fake
  • openstack:fedora-40-64:tests/main/
  • openstack:fedora-40-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • google-arm:ubuntu-core-22-arm-64
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Meulengracht Meulengracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bboozzoo bboozzoo added this to the 2.68 milestone Feb 10, 2025
@bboozzoo bboozzoo merged commit 35ad4ae into canonical:master Feb 10, 2025
61 of 67 checks passed
@bboozzoo bboozzoo deleted the bboozzoo/release-check-initrd-release branch February 10, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants