Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove directory page links #14703

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Feb 4, 2025

Done

  • Remove links to the canonical.com/projects/directory page.

QA

  • Go to /legal/contributors and check that there are no links to the directory page in the first two paragraphs on the page (under the Canonical contributor licence agreement heading).
  • Go to /legal/contributors/faq and check that there is no "Related content" box on the right hand side of the page, and that there is no "What if I have other questions?" at the end of the FAQ.

Issue / Card

https://warthogs.atlassian.net/browse/WD-18958

@webteam-app
Copy link

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (88720fb) to head (62a6418).
Report is 121 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14703   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files         120      120           
  Lines        3404     3404           
  Branches     1174     1172    -2     
=======================================
  Hits         2462     2462           
  Misses        917      917           
  Partials       25       25           

Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huwshimi huwshimi merged commit 709355e into canonical:main Feb 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants