Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

fix(ios): Add missing request error handling #225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): Add missing request error handling #225

wants to merge 1 commit into from

Conversation

mrahn24
Copy link

@mrahn24 mrahn24 commented Jan 27, 2022

resolves #224

@neonish neonish mentioned this pull request Feb 27, 2022
Open
@mrahn24
fix(ios): Add missing request error handling (capacitor-community#224)
4d86ce4 
* fix: Fixed missing request plugin call rejection
* refactor: Adjusted error messages to provide better information
@mrahn24 mrahn24 force-pushed the fix/missing-request-error-handling branch from da0742f to 4d86ce4 Compare February 28, 2022 08:44
@mrahn24 mrahn24 mentioned this pull request Mar 1, 2022
Open
flipace
flipace approved these changes Mar 30, 2022
View reviewed changes
Copy link

@flipace flipace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than nothing tbh 😅

@jwktje
Copy link

jwktje commented Jun 1, 2022

When might this be merged?

@tomsawdayee
Copy link

Any update on this? Please merge this as this is very basic functionality that is missing.
Thanks

@flipace
Copy link

flipace commented Jun 9, 2022

Just a hint, for others who might be waiting on this as well -> We use patch-package to apply the changes of this (and other) PRs on our builds without requiring us to fork.

In such cases where there is a PR already open, you can simply append .patch to the github url to get the patch code: https://github.com/capacitor-community/http/pull/225.patch

This you can put into ./patches/@capacitor-community+http+1.4.1.patch of your project and when you have patch-package installed, it will auto-apply the patch to the package in node_modules whenever you update/install.

@tomsawdayee
Copy link

Wow! Thanks a bunch @flipace ! A perfect workaround for me. I almost went back to old cordova plugins!

@lazarvelickovic lazarvelickovic mentioned this pull request May 29, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flipace flipace flipace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS: request error does not reject plugin call
4 participants
@mrahn24 @jwktje @tomsawdayee @flipace