Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reinstating finished event after end reached was changed to stopping #1132

Open
caprica opened this issue Apr 10, 2022 · 5 comments

Comments

@caprica
Copy link
Owner

caprica commented Apr 10, 2022

The native event manager changed end reached to stopping.

vlcj used end reached for its finished event.

Since stopping does not seem semantically the same as finished, the event was changed in vlcj also.

But it would be better to keep the finished event in vlcj if that is possible.

@caprica caprica added the Task label Apr 10, 2022
@caprica caprica added this to the vlcj 5.0.0 Release milestone Apr 10, 2022
@caprica
Copy link
Owner Author

caprica commented Apr 10, 2022

This is actually tricky.

The stopped event may occur whether the media finished or not - but it is (probably) the most common use-case to know when media actually finished (so the next one can be played).

@caprica
Copy link
Owner Author

caprica commented Apr 10, 2022

This is complicated by the fact that "stopping" now seems to be raised whether the media reached the end or was explicitly stopped - so how do you determine the difference? In this sense, stopping is NOT a compatible replacement for end reached.

@caprica
Copy link
Owner Author

caprica commented Apr 10, 2022

Related to #1133.

@mfkl
Copy link
Contributor

mfkl commented Apr 28, 2022

@caprica
Copy link
Owner Author

caprica commented May 29, 2022

Remember to update README as this is currently called out as a backwards-incompatible API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants