Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed pagination label for select #18166

Conversation

preetibansalui
Copy link
Contributor

Closes #17974

Change label of select to Page instead of Page Number

Testing / Reviewing

  1. Go to Pagination > Default story
  2. Screen reader should announce page 1 of 11 pages when focus is on select menu for page number.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3241cdf
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674d6f785c760900089c9877
😎 Deploy Preview https://deploy-preview-18166--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3241cdf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674d6f7893daf50008870215
😎 Deploy Preview https://deploy-preview-18166--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3241cdf
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674d6f78bd924400084da8ef
😎 Deploy Preview https://deploy-preview-18166--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (29d0f18) to head (3241cdf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18166   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files         404      404           
  Lines       14344    14344           
  Branches     4650     4596   -54     
=======================================
  Hits        11958    11958           
- Misses       2224     2225    +1     
+ Partials      162      161    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SR's announcements are more clear now. It reads "5, page of 11 pages" !! Thanks

@tay1orjones tay1orjones added this pull request to the merge queue Dec 2, 2024
Merged via the queue into carbon-design-system:main with commit 7e63bbf Dec 2, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination] Change Select's label to "Page number"
5 participants