Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vrt test cases of popover #18181

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

preetibansalui
Copy link
Contributor

Closes #18180

Change story id with theme in VRT test case

Testing / Reviewing

It should pass all CI checks

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d9cad7d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674c1ace7c5e2a0008f26856
😎 Deploy Preview https://deploy-preview-18181--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d9cad7d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674c1acea1ee3100083d1a84
😎 Deploy Preview https://deploy-preview-18181--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9cad7d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674c1acebd924400084e345d
😎 Deploy Preview https://deploy-preview-18181--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (29d0f18) to head (d9cad7d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18181   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files         404      404           
  Lines       14344    14344           
  Branches     4650     4596   -54     
=======================================
  Hits        11958    11958           
- Misses       2224     2225    +1     
+ Partials      162      161    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@preetibansalui preetibansalui marked this pull request as draft November 29, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Percy CI-check is failing because of VRT cases of the Popover component.
1 participant