feat: adding events metadata #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiwinnetou
changed the title
matiwinnetou
force-pushed
the
refakt-events
branch
4 times, most recently
from
ec05307 to
bff523b
Compare
matiwinnetou
force-pushed
the
refakt-events
branch
from
bff523b to
f9629d3
Compare
matiwinnetou
commented
Sep 12, 2024
|
|
||
| private String version; | ||
| private String user; | ||
| //private String correlationId; // TODO |
There was a problem hiding this comment.
TODO in future tickets
matiwinnetou
commented
Sep 12, 2024
| val txData = blockchainTransactions.serialisedTxData(); | ||
| val l1SubmissionData = transactionSubmissionService.submitTransaction(txData); | ||
| val l1SubmissionData = transactionSubmissionService.submitTransactionWithPossibleConfirmation(txData); |
There was a problem hiding this comment.
Upon consultation with @satran004 we decided to go for this solution for now but with more clever timeouts.
Ticket to move to a more async, streamlined implementation that allows to submit transactions one by one, one after another without causing UTxO contention issues:
bloxbean/cardano-client-lib#435
M4rc0Russ0
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.