Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rustfmt on save" command and fix issue on case of file not reloading on format #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

knzai
Copy link

@knzai knzai commented Jun 15, 2024

Let me know if you want these split up, or done differently, or don't like them. :)

knzai added 2 commits June 14, 2024 18:07
Textmate reload on filesytem changes isn't dependable, ime. Running the file
contents through rustfmt directly means we don't have to save the file, which
is a little better POLS, imo. Cursor can jump left or right a bit, but line
interpolation works fairly well.
We/you could default it to off if you think that's too aggressive
@knzai
Copy link
Author

knzai commented Jun 15, 2024

It probably needs some error handling etc, but I wanted to get input (hah) first.

@carols10cents
Copy link
Owner

🤷🏻‍♀️ Seems fine to me! You've tested this out locally and it works? Any reason I shouldn't merge this?

@knzai
Copy link
Author

knzai commented Jun 24, 2024

We may want to default it off?

It's a bit obnoxious to pop up an error dialogue every time you try to save with a syntax error. I like it as then I never have to deal with dirty commits. But it could be an adjustment, so perhaps opting in makes more sense? Your call, I can add a commit to default it the other way.

I also only tested on my machines and setups, of course.

@carols10cents
Copy link
Owner

We may want to default it off?

It's a bit obnoxious to pop up an error dialogue every time you try to save with a syntax error. I like it as then I never have to deal with dirty commits. But it could be an adjustment, so perhaps opting in makes more sense? Your call, I can add a commit to default it the other way.

Yeah, let's default to off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants