Support test matchers with only Vips #2767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using the test matchers when neither MiniMagick or Magick are installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using the test matchers when using Vips and neither MiniMagick or Magick are installed. In our case it was falling back to Magick since MiniMagick wasn't available. I didn't see any tests for the matchers and I'm not sure if there is even a good way to test the switching logic. That said, I've tested these changes against our application and they fixed the issue we were seeing.
The one idiosyncrasy is that there isn't a clean way to get the format like with the Magick libraries. The best Vips can do is to tell which loader was used (e.g.
"pngload") which I'm guessing is based on the extension.