refactor: DisputeParameters -> ITournamentParametersProvider
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidanoli
force-pushed
the
feature/tournament-parameters-provider
branch
2 times, most recently
from
ba30d5d to
58497b6
Compare
guidanoli
changed the base branch from
main
to
feature/use-stable-foundry-release
guidanoli
force-pushed
the
feature/tournament-parameters-provider
branch
from
58497b6 to
4162b64
Compare
GCdePaula
previously approved these changes
Feb 9, 2025
| @@ -503,7 +503,7 @@ mod blockchain_reader_tests { | |||
| anvil, | |||
| provider, | |||
| Address::from_hex("0x5fbdb2315678afecb367f032d93f642f64180aa3").unwrap(), | |||
| Address::from_hex("0x0165878a594ca255338adfa4d48449f69242eb8f").unwrap(), | |||
| Address::from_hex("0xa513e6e4b8f2a923d98304ec87f64353c4d5c853").unwrap(), | |||
There was a problem hiding this comment.
We can eventually make this read from test/programs/echo/addresses
There was a problem hiding this comment.
Yes, this would be great.
guidanoli
force-pushed
the
feature/tournament-parameters-provider
branch
from
4162b64 to
d7892f7
Compare
GCdePaula
previously approved these changes
Feb 10, 2025
GCdePaula
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies deploying code.