Issue 108: Subblocks duplicated when a custom page is duplicated #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumaiyamannan
force-pushed
the
workplace
branch
from
f094716 to
eec7509
Compare
danmarsden
reviewed
Jan 20, 2025
| * @return void | ||
| */ | ||
| private function cleanup($contextid) { | ||
| global $DB; |
There was a problem hiding this comment.
is it possible to add something like the if ($instance->pagetypepattern == 'admin-tool-custompage') { check in here so that we don't have to check if there a duplicates on every block load? - or maybe even an if tool_custompage plugin exists kind of thing?
sumaiyamannan
force-pushed
the
workplace
branch
from
eec7509 to
1834d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kia ora,
This will resolve the issue 108
Testing instructions:
Go to Moodle Workplace -> Admin -> Custom pages
Click on a page with multiblocks and click 'Duplicate page'
Go to the original page has the multiblock items duplicated
Delete the duplicated page and apply the commit
Duplicate the page again and go to original page and see that no block items are duplicated.
Cheers,
Sumaiya