-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk upload suppress emails #168
Conversation
23fb14c
to
62ea50c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes here looks good. Thanks for adding in the tests.
Are you able to consider the feedback comments and once ready, add a commit to also bump the version.
Also noting that ideally this would land in 403 stable before it is backported to 400. Perhaps we should merge it in that order, if you could prepare a PR for that.
Thanks @matthewhilton.
62ea50c
to
e1b2639
Compare
0a4b75a
to
6c032f0
Compare
Confirming I have rebased and changed the target to Note - After locally testing this, I found a new error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for making the changes Matt.
Changes
$courseid
$session
Testing