Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Spyglass Compatibility to the conversion #11

Merged
merged 46 commits into from
Feb 25, 2025
Merged

Adding Spyglass Compatibility to the conversion #11

merged 46 commits into from
Feb 25, 2025

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Jan 16, 2025 •
edited
Loading

Ephys Recording

  • Spyglass-compatible mock
  • ingestion pipeline
  • implement changes in the conversion

Ephys Sorting

  • Spyglass-compatible mock
  • ingestion pipeline
  • implement changes in the conversion

DLC

Spyglass team is taking care of this one: LorenFrankLab/spyglass#1225

Behavior (DIO Events)

  • Spyglass-compatible mock
  • ingestion pipeline
  • implement changes in the conversion

Epochs/Tasks

  • Spyglass-compatible mock
  • ingestion pipeline
  • implement changes in the conversion

Video

  • Spyglass-compatible mock
  • ingestion pipeline
  • implement changes in the conversion

LFP

@pauladkisson pauladkisson mentioned this pull request Jan 16, 2025
Open
23 tasks
@pauladkisson pauladkisson mentioned this pull request Jan 29, 2025
Open
7 tasks
@pauladkisson pauladkisson marked this pull request as ready for review February 19, 2025 20:21
alessandratrapani
alessandratrapani reviewed Feb 21, 2025
View reviewed changes
alessandratrapani
alessandratrapani reviewed Feb 21, 2025
View reviewed changes
src/jadhav_lab_to_nwb/olson_2024/olson_2024_insert_session.py
UnitAnnotation().add_annotation(annotation_key, skip_duplicates=True)


def insert_lfp(nwbfile_path: Path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some comments here?

Copy link
Member Author

@pauladkisson pauladkisson Feb 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some docstrings, does that satisfy the extra info that you're asking for?

alessandratrapani
alessandratrapani reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comments, mostly documentation-related.
Do you have a stub version of the nwbfile?

@pauladkisson
Copy link
Member Author

Do you have a stub version of the nwbfile?

Yep, here's a folder with both a single-epoch and multi-epoch stubbed .nwb file: https://drive.google.com/drive/folders/1mu5lOioewTsKjXN1sQ49JDYCre9G6SBX?usp=drive_link

@pauladkisson pauladkisson merged commit b5d6be5 into main Feb 25, 2025
@pauladkisson pauladkisson deleted the ndx-franklab branch February 25, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandratrapani alessandratrapani alessandratrapani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauladkisson @alessandratrapani