Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some duplicate ecephys tests #1032

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Remove some duplicate ecephys tests #1032

merged 3 commits into from
Aug 28, 2024

Conversation

h-mayorquin
Copy link
Collaborator

As in the title. Remove a bunch of recording tests that were duplicated.

@h-mayorquin h-mayorquin self-assigned this Aug 27, 2024
@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Aug 27, 2024

Dev tests are failing because of this:

NeuralEnsemble/python-neo#1532

@h-mayorquin h-mayorquin marked this pull request as ready for review August 27, 2024 19:42
@h-mayorquin h-mayorquin enabled auto-merge (squash) August 27, 2024 19:43
@h-mayorquin h-mayorquin merged commit 8522241 into main Aug 28, 2024
33 of 35 checks passed
@h-mayorquin h-mayorquin deleted the remove_duplicate_test branch August 28, 2024 03:17
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (727228c) to head (ba66186).
Report is 83 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   90.67%   90.41%   -0.26%     
==========================================
  Files         129      129              
  Lines        7879     7919      +40     
==========================================
+ Hits         7144     7160      +16     
- Misses        735      759      +24     
Flag Coverage Δ
unittests 90.41% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants