Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary supress failing plexon #1043

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Temporary supress failing plexon #1043

merged 1 commit into from
Aug 29, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Plexon 2 is unreliable on its opening and it has been getting on the way of CI doc testing. Steps have already been taken to improve the situation but meanwhile I am disabling this doctest by removing the code directive >>>

NeuralEnsemble/python-neo#1541

@h-mayorquin
Copy link
Collaborator Author

It was succesfully skipped:

image

https://github.com/catalystneuro/neuroconv/actions/runs/10621357464/job/29443137429?pr=1043

This looks OK in the docs:

https://neuroconv--1043.org.readthedocs.build/en/1043/conversion_examples_gallery/recording/plexon2.html

Consider use this in the future (which is less drastic of a diff and seems more convenient but adds an extra dependency)
https://github.com/scientific-python/pytest-doctestplus

@h-mayorquin h-mayorquin marked this pull request as ready for review August 29, 2024 19:33
@h-mayorquin h-mayorquin enabled auto-merge (squash) August 29, 2024 19:33
@h-mayorquin h-mayorquin merged commit b5ca011 into main Aug 29, 2024
22 checks passed
@h-mayorquin h-mayorquin deleted the fix_failing_docstring branch August 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants