Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some methods private #1050

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Make some methods private #1050

merged 3 commits into from
Sep 2, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@CodyCBakerPhD

These are methods that we don't want to make guarantee and we also don't believe should be on the API docs. I am making them private. We can change them if the needs come to be.

@h-mayorquin h-mayorquin self-assigned this Sep 1, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review September 1, 2024 20:18
@CodyCBakerPhD
Copy link
Member

Note that though this marks them as private, they are all still publically exposed to the submodules

@CodyCBakerPhD CodyCBakerPhD merged commit e73745a into main Sep 2, 2024
34 of 35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the make_some_methods_private branch September 2, 2024 06:09
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (905dc73) to head (cfebd14).
Report is 69 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   90.42%   90.40%   -0.02%     
==========================================
  Files         129      129              
  Lines        7924     7924              
==========================================
- Hits         7165     7164       -1     
- Misses        759      760       +1     
Flag Coverage Δ
unittests 90.40% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/basedatainterface.py 94.44% <100.00%> (ø)
...aces/behavior/neuralynx/neuralynx_nvt_interface.py 98.33% <100.00%> (ø)
...tainterfaces/ecephys/mearec/mearecdatainterface.py 100.00% <100.00%> (ø)
src/neuroconv/nwbconverter.py 94.81% <100.00%> (ø)
src/neuroconv/tools/roiextractors/__init__.py 100.00% <ø> (ø)
src/neuroconv/tools/roiextractors/roiextractors.py 82.18% <100.00%> (ø)
...c/neuroconv/tools/testing/data_interface_mixins.py 95.33% <100.00%> (ø)
src/neuroconv/utils/__init__.py 50.00% <ø> (ø)
src/neuroconv/utils/dict.py 93.97% <100.00%> (ø)
src/neuroconv/utils/json_schema.py 96.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants