Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganized weeklies into dedicated workflow like dailies #1088

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

pauladkisson
Copy link
Member

Continuation of #1081 for weekly workflows.

@pauladkisson
Copy link
Member Author

@CodyCBakerPhD, for my own understanding, what is the reason that Build and Upload Docker Image of Rclone With Config to GHCR only runs weekly while all the rest of the active workflows run daily?

@CodyCBakerPhD
Copy link
Member

for my own understanding, what is the reason that Build and Upload Docker Image of Rclone With Config to GHCR only runs weekly while all the rest of the active workflows run daily?

The base image for rclone is not assumed to update that regularly or that its updates are not that important

Could maybe even go down to monthly

Main edge case benefit is that you gain access to new service providers (but most of our expected usage is drive/dropbox anyway)

@pauladkisson
Copy link
Member Author

The base image for rclone is not assumed to update that regularly or that its updates are not that important

Ok, sounds good.

@pauladkisson pauladkisson marked this pull request as ready for review September 17, 2024 01:05
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put the formatwise gallyer tests here as well?

https://github.com/catalystneuro/neuroconv/blob/fddd4d28cb7839920479d8154f49417f78a391af/.github/workflows/formatwise-installation-testing.yml#L1-L73

Also, maybe the dev tests? They are on the dailies but we won't be able to fix them on a daily basis so once you get the notification once you will keep getting the notification every day. I guess that's your call.

@pauladkisson
Copy link
Member Author

Should we put the formatwise gallyer tests here as well?

Those are disabled, so I didn't include them.

@pauladkisson
Copy link
Member Author

Also, maybe the dev tests?

No, I definitely want to know about the dev tests on a daily basis.

@h-mayorquin
Copy link
Collaborator

Should we put the formatwise gallyer tests here as well?

Those are disabled, so I didn't include them.

OK, I think we should activate them. But that's outside of the scope of this PR.

@pauladkisson pauladkisson enabled auto-merge (squash) September 18, 2024 19:08
@pauladkisson pauladkisson merged commit 60cc8c7 into main Sep 19, 2024
43 checks passed
@pauladkisson pauladkisson deleted the weeklies branch September 19, 2024 01:41
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (36464df) to head (65b4bcf).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         129      129           
  Lines        8055     8050    -5     
=======================================
- Hits         7285     7281    -4     
+ Misses        770      769    -1     
Flag Coverage Δ
unittests 90.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants