Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add always_write_timestamps method to base recording interfaces #1091

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Should close #712.

@h-mayorquin h-mayorquin marked this pull request as ready for review September 18, 2024 01:12
@h-mayorquin h-mayorquin merged commit f51c6fa into main Sep 19, 2024
43 checks passed
@h-mayorquin h-mayorquin deleted the force_timestamps_writing branch September 19, 2024 12:38
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (36464df) to head (cfe26a0).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.02%     
==========================================
  Files         129      129              
  Lines        8055     8055              
==========================================
+ Hits         7285     7287       +2     
+ Misses        770      768       -2     
Flag Coverage Δ
unittests 90.46% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erfaces/ecephys/baserecordingextractorinterface.py 93.81% <ø> (ø)
...c/neuroconv/tools/spikeinterface/spikeinterface.py 90.85% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants