Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev tests from the PR tests #1092

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

h-mayorquin
Copy link
Collaborator

As in the title. From the discussion on #1082 (comment)

@h-mayorquin h-mayorquin added the CI label Sep 17, 2024
@h-mayorquin h-mayorquin self-assigned this Sep 17, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review September 17, 2024 23:54
@h-mayorquin h-mayorquin changed the title Remove dev tests from the CI Remove dev tests from the PR tests Sep 18, 2024
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a dispatch of deploy-tests.yml to ensure it's working properly.

CHANGELOG.md Outdated Show resolved Hide resolved
@h-mayorquin
Copy link
Collaborator Author

I'd like to see a dispatch of deploy-tests.yml to ensure it's working properly.

What do you think could show up that is not showing up here in the PR? I just removed them from deploy.test.

@pauladkisson
Copy link
Member

I'd like to see a dispatch of deploy-tests.yml to ensure it's working properly.

What do you think could show up that is not showing up here in the PR? I just removed them from deploy.test.

You know what, this is a dumb request -- I forgot that the PR triggers this workflow.

@h-mayorquin h-mayorquin enabled auto-merge (squash) September 19, 2024 13:47
@h-mayorquin h-mayorquin merged commit 1ccdb2a into main Sep 19, 2024
39 checks passed
@h-mayorquin h-mayorquin deleted the remove_dev_test_from_deploy branch September 19, 2024 18:16
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (36464df) to head (f1fcdcb).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.02%     
==========================================
  Files         129      129              
  Lines        8055     8055              
==========================================
+ Hits         7285     7287       +2     
+ Misses        770      768       -2     
Flag Coverage Δ
unittests 90.46% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants