Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable zarr backend testing in data tests [3] #1094

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Conversation

h-mayorquin
Copy link
Collaborator

Final follow-up on #1083.

This checks that passing a backend_configurator object works with both zarr and hdf5.

@h-mayorquin h-mayorquin self-assigned this Sep 18, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review September 18, 2024 18:55
@h-mayorquin h-mayorquin merged commit 7ea96d8 into main Sep 23, 2024
39 checks passed
@h-mayorquin h-mayorquin deleted the even_more_zarr_test branch September 23, 2024 16:53
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (36464df) to head (38e0104).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
+ Coverage   90.44%   90.58%   +0.13%     
==========================================
  Files         129      129              
  Lines        8055     8164     +109     
==========================================
+ Hits         7285     7395     +110     
+ Misses        770      769       -1     
Flag Coverage Δ
unittests 90.58% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/neuroconv/tools/testing/data_interface_mixins.py 95.62% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants