-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mixing tests for mocks #1136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but we should remove the 'old' Test classes before we merge right?
I remove the ones from the Old Recording Extractor. I don't really like the stub tests were done in the old tests. Since those were written I have written better machinery on the SpikeInterface side. I will update those in a separate PR though and then remove the old ones. |
I see, so you'll remove those old tests after #1124 is ready to go? |
Also looks like test_no_slash_in_name is failing... |
Should be fixed now. |
Sounds good. As long as we have a clear plan to remove it, so it doesn't just end up hanging around with a comment saying it should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, but should pass after #1140 gets merged.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 90.60% 90.58% -0.02%
==========================================
Files 129 128 -1
Lines 8174 8011 -163
==========================================
- Hits 7406 7257 -149
+ Misses 768 754 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We have specific tests for the mock recording interface that duplicates the tests on the mixing. This PR solves this by using the mixing tests for the mock (We already doing that in the ophys side).
This PR also separates some changes that I did on #1124 and should come before it.