[Draft] Make dynamic tables expandable #1137
Draft
+59
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sup, @bendichter I wanted to write this here so we have an anchor point for discussion next time we meet. Taking the electrodes table as a starting point there are two objects that we are not catching for chunkg at the moment:
Check the code below for more comments but the gist of where I got stuck is here:
For the ids, the data was chunk but the maxshape was also so it becomes non-expandable.
Important, note that for hdf5 we only pass chunk to the DataIO:
https://github.com/catalystneuro/neuroconv/blob/df9d6f84a70f0840d78c09c42dd6e67afd24ff3c/src/neuroconv/tools/nwb_helpers/_configuration_models/_zarr_dataset_io.py#L132-L133