Move timeintervals schema to schemas/ dir to include in build
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Existing tests should in principle be enough for this PR |
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 98 98
Lines 5174 5175 +1
=======================================
+ Hits 4719 4720 +1
Misses 455 455
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pip installing
neuroconvfrom PyPI,timeintervals.schema.jsonisn't being included for some reason, despite theinclude *.jsonline inMANIFEST.in. Seemed easiest/safest to move it toschemas/dir which is consistently included.