Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cellexplorer #582

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix cellexplorer #582

merged 2 commits into from
Sep 28, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Sep 28, 2023

I'm getting some errors in the CI

@CodyCBakerPhD
Copy link
Member

Thanks for catching this; opened #583 to resolve going into the future

Dev test failures are unrelated, this fix looks good for main CI

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 28, 2023 18:54
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #582 (4f53262) into main (d812794) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   91.21%   91.21%   -0.01%     
==========================================
  Files          98       98              
  Lines        5182     5181       -1     
==========================================
- Hits         4727     4726       -1     
  Misses        455      455              
Flag Coverage Δ
unittests 91.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../ecephys/cellexplorer/cellexplorerdatainterface.py 84.39% <100.00%> (-0.08%) ⬇️

@CodyCBakerPhD CodyCBakerPhD merged commit 639a9fd into main Sep 28, 2023
31 of 36 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_cellexplorer branch September 28, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants