Add support for adding OnePhotonSeries/TwoPhotonSeries to processing module
#587
Conversation
…o add_photon_series_to_module
src/neuroconv/datainterfaces/ophys/baseimagingextractorinterface.py
Outdated
Show resolved
Hide resolved
# Conflicts: # tests/test_ophys/test_tools_roiextractors.py
| parent_container: {'acquisition', 'processing/ophys'}, optional | ||
| The container where the photon series is added, default is nwbfile.acquisition. | ||
| When 'processing/ophys' is chosen, the photon series is added to nwbfile.processing['ophys']. |
There was a problem hiding this comment.
@h-mayorquin is this clear enough?
There was a problem hiding this comment.
Sorry for not answering this before, @weiglszonja. For what is worth even if the issue is merged, this looks great to me.
There was a problem hiding this comment.
thank you! sorry for not pinging before the merge..
There was a problem hiding this comment.
Not at all, I am glad you guys worked out. I am happy that I could helped you review the other PR and thankful for Cody time on reviewing this one. Seems like a good distribution of work!
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 90.78% 90.80% +0.01%
==========================================
Files 103 103
Lines 5374 5382 +8
==========================================
+ Hits 4879 4887 +8
Misses 495 495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
LGTM |
|
Thank you @CodyCBakerPhD, I'll merge this. |
Resolve #581
Add
parent_containerargument toadd_photon_seriesthat defines where to add the photon series (nwbfile.acquisitionornwbfile.processing["ophys"]).