-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add complete session start time to FicTrac #598
Conversation
Oh, I thought that Related: |
src/neuroconv/datainterfaces/behavior/fictrac/fictracdatainterface.py
Outdated
Show resolved
Hide resolved
src/neuroconv/datainterfaces/behavior/fictrac/fictracdatainterface.py
Outdated
Show resolved
Hide resolved
src/neuroconv/datainterfaces/behavior/fictrac/fictracdatainterface.py
Outdated
Show resolved
Hide resolved
…ity_to_fictrac' into add_time_functionality_to_fictrac
src/neuroconv/datainterfaces/behavior/fictrac/fictracdatainterface.py
Outdated
Show resolved
Hide resolved
@@ -37,6 +37,10 @@ class TestFicTracDataInterface(DataInterfaceTestMixin, unittest.TestCase): | |||
|
|||
save_directory = OUTPUT_PATH | |||
|
|||
def check_extracted_metadata(self, metadata: dict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, before merge, can we get a test for the new starting time functionality? Or is the example data irregular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is irregular in the example : (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to add the timing methods soon, that will be tested there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be possible to do this once it becomes a Temporally aligned interface; the ability to override those fetched timestamps, you could override it to something regular in a test
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 91.09% 90.98% -0.11%
==========================================
Files 103 103
Lines 5356 5369 +13
==========================================
+ Hits 4879 4885 +6
- Misses 477 484 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
When working on the Clandining conversion I realized that the first line of the data header has non-valid values save the timestamp. The timestamp is the unix time epoch in milliseconds which can be used to extract a more complete
session_start_time
as previously we were extracting only the date.I did some other improvements to the code like adding
starting_time
when they are not zero which were not done before.