-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Suite2pSegmentationInterface
to support multiple channels and planes
#601
Conversation
src/neuroconv/datainterfaces/ophys/suite2p/suite2pdatainterface.py
Outdated
Show resolved
Hide resolved
Noticed an issue with the extractor, as it overrides the |
…update_Suite2P_multiplane
for more information, see https://pre-commit.ci
@weiglszonja @alessandratrapani Will be pushing for a new roiextractors release tomorrow; is this PR ready to go once that happens? |
@CodyCBakerPhD on my end it is, I just listed @alessandratrapani for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks all right to me
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 91.73% 91.80% +0.07%
==========================================
Files 108 108
Lines 5712 5762 +50
==========================================
+ Hits 5240 5290 +50
Misses 472 472
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Update Suite2pSegmentationExtractor to support multiple channels and planes Update
Suite2pSegmentationExtractor
to support multi channel and multi plane outputs roiextractors#242Update all necessary metadata (Created [Discussion]: Adding traces and segmentation images from a second channel (and/or plane) #603 to discuss these questions)
Add test for stubbing, as mentioned in Add Suite2pSegmentationInterface NeurodataWithoutBorders/nwb-guide#460 (comment)
Update docs for usage example
Remove pin for roiextractors