Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable H5DataIO compression if compression is None #699

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

alejoe91
Copy link
Contributor

@alejoe91 alejoe91 commented Jan 2, 2024

Disables hardcoded H5DataIO wrapping in tools.spikeinterface.write_recording if compression=None.

This change enables one to use the configure_backend functionality (added a note in the docstring)

@alejoe91
Copy link
Contributor Author

alejoe91 commented Jan 2, 2024

Closing in favor of #578

@alejoe91 alejoe91 closed this Jan 2, 2024
@CodyCBakerPhD
Copy link
Member

#578 still needs a little work to debug some stuff

I'd be fine with this one for now; also no need to add a test since those options are to be deprecated in the follow-up anyway

@alejoe91 alejoe91 reopened this Jan 2, 2024
@alejoe91
Copy link
Contributor Author

alejoe91 commented Jan 2, 2024

Then I'll reopen! Couldn't test the full thing for the issue on set_data_io for tables, but electrical series worked fine when configured with a Zarr compressor!

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0be73d9) 92.23% compared to head (34483f5) 92.20%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   92.23%   92.20%   -0.03%     
==========================================
  Files         115      115              
  Lines        5950     5954       +4     
==========================================
+ Hits         5488     5490       +2     
- Misses        462      464       +2     
Flag Coverage Δ
unittests 92.20% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/neuroconv/tools/spikeinterface/spikeinterface.py 92.75% <71.42%> (-0.37%) ⬇️

@CodyCBakerPhD CodyCBakerPhD merged commit 1ddfe22 into main Jan 2, 2024
51 of 71 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the configure-backend-spikeinterface-tools branch January 2, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants