-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImagingExtractor #365
base: 0.6.0dev
Are you sure you want to change the base?
Conversation
…wn private methods
A roadmap for future PRs for this dev effort:
|
Hey, this escaped my radar. Let's have a call once you are back from the retreat to have a brief discussion before I do a full review. |
What do you say of peeling this appart to get smaller improvements through? I think that Ben will be on board with removing writing capabilities. I would also like to remove What do you say if you take the first (removing writing) and I take the second (removing channel related methods)? Then I think what's left will be the renaming? |
Sure!
And I also revamped the tests to make them much more modular. |
This PR is the first of a series that implement breaking changes to fully standardize the roiextractors api and update/streamline the testing suite. Some of the main goals include
This PR focuses on
ImagingExtractor
,FrameSliceImagingExtractor
, andNumpyImagingExtractor