-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build hyprcursor with svgs (again) #55
fix: build hyprcursor with svgs (again) #55
Conversation
I'd like to confirm that this does fix recent (potentially all?) issues raised with regards to Hyprland. The artifacts have been built as part of this PR and I'd greatly appreciate if @kerichdev / @arminius-smh / @JonathanSteininger / @jinliu could test it out and confirm that it fixes some or all issues. Thanks! |
I haven't tested this. But a note to fellow testers: Hyprcursor specifies actual image size instead of nominal size, so for this theme, a Hyprcursor size 32 corresponds to XCURSOR_SIZE 24. If you set Hyprcursor size to 24, the cursor would be smaller and blurry. |
Arminius over on the Discord has confirmed the cursors work and dont have any obvious issues |
941cea6
to
f9e7289
Compare
Can confirm this works. Tested in Hyprland with Qt/KDE apps and Kitty, which uses Hyprcursor through the Wayland cursor_shape_v1 protocol. |
Catppuccin has a 1.333... ratio nominal:actual size. maybe a note should be added to the README for hyprcursor users to do this conversion when setting their size. Something like: "hyprcursor has no concept of nominal size which we rely on. when running |
as mentioned in catppuccin#53 (comment). Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on `hyprcursor-util` & `xcur2png` is gone.
f9e7289
to
88e5428
Compare
632e5e3
to
21e82a2
Compare
removed unused items fixed indents
8d6f00e
to
d52431d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Happy to merge since it's been tested by hyprland users
fixes #53
Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on
hyprcursor-util
&xcur2png
is gone.some discussion might be had about the build scripts and legacy stuff.