Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build hyprcursor with svgs (again) #55

Merged

Conversation

Covkie
Copy link
Contributor

@Covkie Covkie commented Nov 26, 2024

fixes #53

Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on hyprcursor-util & xcur2png is gone.

some discussion might be had about the build scripts and legacy stuff.

@sgoudham
Copy link
Contributor

I'd like to confirm that this does fix recent (potentially all?) issues raised with regards to Hyprland.

The artifacts have been built as part of this PR and I'd greatly appreciate if @kerichdev / @arminius-smh / @JonathanSteininger / @jinliu could test it out and confirm that it fixes some or all issues.

Thanks!

@jinliu
Copy link

jinliu commented Nov 27, 2024

I haven't tested this. But a note to fellow testers: Hyprcursor specifies actual image size instead of nominal size, so for this theme, a Hyprcursor size 32 corresponds to XCURSOR_SIZE 24. If you set Hyprcursor size to 24, the cursor would be smaller and blurry.

@Covkie
Copy link
Contributor Author

Covkie commented Nov 27, 2024

Arminius over on the Discord has confirmed the cursors work and dont have any obvious issues

@Covkie Covkie force-pushed the scripts/refactor-hyprcursor+svgified branch from 941cea6 to f9e7289 Compare November 27, 2024 04:27
@jinliu
Copy link

jinliu commented Nov 27, 2024

Can confirm this works. Tested in Hyprland with Qt/KDE apps and Kitty, which uses Hyprcursor through the Wayland cursor_shape_v1 protocol.

@Covkie
Copy link
Contributor Author

Covkie commented Nov 27, 2024

I haven't tested this. But a note to fellow testers: Hyprcursor specifies actual image size instead of nominal size, so for this theme, a Hyprcursor size 32 corresponds to XCURSOR_SIZE 24. If you set Hyprcursor size to 24, the cursor would be smaller and blurry.

Catppuccin has a 1.333... ratio nominal:actual size. maybe a note should be added to the README for hyprcursor users to do this conversion when setting their size. Something like: "hyprcursor has no concept of nominal size which we rely on. when running hyprctl setcursor multiply your target size by 1.333..."
(maybe an issue should be opened for hyprctl to do this automatically if nominal size usage is detected in the xcursor OR hyprcursor should implement nominal size)

as mentioned in catppuccin#53 (comment).

Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on `hyprcursor-util` & `xcur2png` is gone.
@Covkie Covkie force-pushed the scripts/refactor-hyprcursor+svgified branch from f9e7289 to 88e5428 Compare November 27, 2024 18:37
@Covkie Covkie requested a review from sgoudham November 28, 2024 22:05
@Covkie Covkie force-pushed the scripts/refactor-hyprcursor+svgified branch from 632e5e3 to 21e82a2 Compare November 28, 2024 22:07
@sgoudham sgoudham changed the title feat: build hyprcursor with svgs fix: build hyprcursor with svgs (again) Dec 1, 2024
removed unused items
fixed indents
@Covkie Covkie force-pushed the scripts/refactor-hyprcursor+svgified branch from 8d6f00e to d52431d Compare December 1, 2024 02:44
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Happy to merge since it's been tested by hyprland users

@sgoudham sgoudham linked an issue Dec 3, 2024 that may be closed by this pull request
@sgoudham sgoudham merged commit fc88cfb into catppuccin:main Dec 3, 2024
1 check passed
@Covkie Covkie deleted the scripts/refactor-hyprcursor+svgified branch December 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursors not showing sometimes Cursor rescaling/resizing does not work on Hyprland
3 participants