Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tidal): init #1560

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Thomas-Philippot
Copy link
Contributor

🎉 Theme for Tidal web 🎉

Tidal is a music streaming platform

1

💬 Additional Comments 💬

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the userstyles.yml file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.less - all the CSS for the userstyle, based on the template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@uncenter
Copy link
Member

uncenter commented Jan 6, 2025

CleanShot 2025-01-06 at 09 32 51

Noticing lots of unthemed text. (Also, love the songs you are playing :p)

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Jan 6, 2025
@uncenter
Copy link
Member

No need to update this branch often with merges.

@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Jan 17, 2025
@uncenter
Copy link
Member

uncenter commented Feb 1, 2025

Sorry for the long wait.

Source code looks great, I don't have a subscription though (I don't think I can access it) so I will take your word for it and do a minimal review based on the preview image.

CleanShot 2025-01-31 at 21 22 22

(Also, text in the play button looks unthemed - if you do make it accent youll have to change it to crust anyway though)

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Feb 1, 2025
@uncenter
Copy link
Member

uncenter commented Feb 1, 2025

Signup/login modal when not signed in:
CleanShot 2025-01-31 at 21 26 24

@Thomas-Philippot
Copy link
Contributor Author

I took some more recents screenshots

catwalk_1
catwalk

@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Feb 12, 2025
@uncenter
Copy link
Member

Sorry for the long wait.

Source code looks great, I don't have a subscription though (I don't think I can access it) so I will take your word for it and do a minimal review based on the preview image.

CleanShot 2025-01-31 at 21 22 22

(Also, text in the play button looks unthemed - if you do make it accent youll have to change it to crust anyway though)

Can you double check that the issues mentioned here are all resolved? I still think we should make the play button (the big one to the left of the shuffle button?) accent-colored, I can't quite tell if the track numbers are themed either. I also can't tell from the new screenshots of the "track title being themed in latte but not in frappe" issue was fixed, as pointed out in my earlier marked up image for that track with the really long title.

@Thomas-Philippot
Copy link
Contributor Author

juste made these changes :

  • Properly theme the modals (including the login/signup)
  • Author name from subtext0 to subtext1 (can confirm it looks better)
  • Accent color on big play button from album/playlist page
  • Theme the track numbers

I also checked the other text and can confirm that the are themed to @text.
will follow a new catwalk from the same album page so we can compare

@Thomas-Philippot
Copy link
Contributor Author

catwalk-ezgif com-webp-to-png-converter

@uncenter
Copy link
Member

Looks like the album title in latte isn't themed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants