-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tidal): init #1560
base: main
Are you sure you want to change the base?
feat(tidal): init #1560
Conversation
No need to update this branch often with merges. |
Sorry for the long wait. Source code looks great, I don't have a subscription though (I don't think I can access it) so I will take your word for it and do a minimal review based on the preview image. (Also, text in the play button looks unthemed - if you do make it accent youll have to change it to crust anyway though) |
Can you double check that the issues mentioned here are all resolved? I still think we should make the play button (the big one to the left of the shuffle button?) accent-colored, I can't quite tell if the track numbers are themed either. I also can't tell from the new screenshots of the "track title being themed in latte but not in frappe" issue was fixed, as pointed out in my earlier marked up image for that track with the really long title. |
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
juste made these changes :
I also checked the other text and can confirm that the are themed to |
Looks like the album title in latte isn't themed? |
I had readability issues with a "black" text on a couple of dark album covers I feel like the Would you like to see some examples? |
Sure yeah lets go with base/crust. |
Hi, I think we can remove the "waiting on author" tag. Note that listen.tidal.com is now available to browse without an account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we theme this login modal logo?
It would also be nice if we could make the sign up button have a slight effect on hover like the original button does.
The E explicit symbol appears unthemed.
The gradient effect toward the bottom of this queue modal is unthemed.
Credits pages (e.g. https://listen.tidal.com/credits/4332277) have this unthemed tabs/tags.
The play arrow in the center of these circles on album cover hover has poor contrast (base/crust here maybe?).
🎉 Theme for Tidal web 🎉
Tidal is a music streaming platform
💬 Additional Comments 💬
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.catppuccin.user.less
- all the CSS for the userstyle, based on the template.preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.