Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinterest): misc #1581

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

fix(pinterest): misc #1581

wants to merge 69 commits into from

Conversation

nuexq
Copy link
Contributor

@nuexq nuexq commented Jan 16, 2025

🔧 What does this fix? 🔧

add multiple messing variables like --color-background-box-info-weak, --color-background-tabs-base...

  • adding --color-background-box-info-weak variable
  • adding --color-text-formfield-default variable
  • adding --color-background-tabs-(base/hover) variables
  • edit --color-background-box-light to match bg color
  • remove the @text style for pin hover icons (doesn't match there bg)
  • change pin hover icons bg to match theme
  • adding switch background and borders variables
  • adding checkbox background and borders variables
  • adding --color-background-button-white-(default/hover) variables
  • new input UI fix
  • new nav icons fix

🗒 Checklist 🗒

@github-actions github-actions bot added the pinterest Pinterest label Jan 16, 2025
@uncenter uncenter changed the title fix(Pinterest): adding multiple messing variables + fixing pin hover icon colors fix(pinterest): variables & pin hover icon Jan 16, 2025
@uncenter uncenter marked this pull request as draft January 17, 2025 17:48
@nuexq nuexq changed the title fix(pinterest): variables & pin hover icon fix(pinterest): multiple fixes Jan 18, 2025
@nuexq
Copy link
Contributor Author

nuexq commented Feb 6, 2025

Issue Description

I seem to be getting gaps on the top bar

Could you please clarify which page this is? I did not encounter like that problem before.

I do not have this icon on my navigation:
Missing Icon

my navigation:
My Navigation

I also believe the notification icon is broken after it receives notification states.

Furthermore, I am encountering a grey loading background on some pages also, and I'm working on it.

Thank you for your review!

@isabelroses
Copy link
Member

Could you please clarify which page this is? I did not encounter like that problem before.

I seem to notice the issues on https://uk.pinterest.com/ when logged in on the homepage

@nuexq
Copy link
Contributor Author

nuexq commented Feb 6, 2025

I seem to notice the issues on https://uk.pinterest.com/ when logged in on the homepage

I tried going to https://uk.pinterest.com, but nothing new appeared.
and also that navigation compass icon didn't showed.

@uncenter uncenter requested a review from isabelroses February 7, 2025 21:51
@isabelroses
Copy link
Member

Perhaps try https://uk.pinterest.com/today/

@nuexq
Copy link
Contributor Author

nuexq commented Feb 8, 2025

Perhaps try https://uk.pinterest.com/today/

It just redirect me to the home page /

@isabelroses
Copy link
Member

Perhaps try https://uk.pinterest.com/today/

It just redirect me to the home page /

Thats really weird. I also tried accessing that page logged out and on a different device, neither time i could replicate that.

@nuexq
Copy link
Contributor Author

nuexq commented Feb 8, 2025

switched my account country to uk and it show now.

I seem to be getting gaps on the top bar

but I'm not getting any suggestion bar

@nuexq
Copy link
Contributor Author

nuexq commented Feb 11, 2025

the new UI is totally fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinterest Pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants