-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(google-contacts): init #1649
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: uncenter <[email protected]>
I'll merge in the requested changes regarding the RGB variables and the hardcoded colours in a bit: then we can move onto resolving the accent container colours. |
I'll try to test this on various Google Workspace plans later today to see if there's any CSS differences that need to be corrected. |
There's some things that aren't themed on higher Google Workspace plans like delegates and the name plate: I'll fix those up then you can review. Could you also look into the Latte style rules not working: I still haven't figured it out and left a comment in the file for you to look at. |
Oops: I meant to merge my latest commits first, please wait a few minutes |
That should be good. |
@uncenter Ready for review! |
I noticed that GitHub says that there's requested changes that need to be resolved: however, I'm not actually sure what needs to be changed. Could that be pointed out? |
There are no changes requested at the moment, I have not re-reviewed. Until then though please see to the linter errors. |
Never mind, the linter is throwing a fit that I'll see to later. Ignore for now. |
Noticed the checkbox for |
Nope, that appears to have been a misclick. |
🎉 Theme for Website 🎉
Google Contacts is a contact management application for G Suite, also known as Google Workspace.
💬 Additional Comments 💬
I struggle with differentiating certain colours, so I may have left certain colour combos that are not very legible together. When reviewing please point them out to me and I will try my best to fix them.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.catppuccin.user.less
- all the CSS for the userstyle, based on the template.preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.