Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chess.com): arrow and square highlights #1651

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Conversation

nuexq
Copy link
Member

@nuexq nuexq commented Mar 11, 2025

🔧 What does this fix? 🔧

Fixes #1606.

image

  • arrow 4 variant color fix
  • highlight 4 variant color fix

🗒 Checklist 🗒

Sorry, something went wrong.

@nuexq nuexq requested a review from uncenter as a code owner March 11, 2025 21:27
@github-actions github-actions bot added the chess.com Chess.com label Mar 11, 2025
@nuexq
Copy link
Member Author

nuexq commented Mar 11, 2025

I've noticed that there is a @var for selecting highlight color, but there is 4 variant of them in the website but the theme make you select just one?

@uncenter
Copy link
Member

That is correct, see #1606. Not intentional, I just wasn't aware. If you would like to, I would love if you could implement those additional variables and style them when appropriate to close that issue!

@nuexq
Copy link
Member Author

nuexq commented Mar 11, 2025

do I need to make them configurable or just using the red/peach/blue/green like the arrows and remove the @var for highlightColor ?

@uncenter
Copy link
Member

I originally made it configurable so that the highlight colors wouldn't clash with your chosen accent color (if you had a blue accent, those arrows/highlights would be hard to see!). I think we should continue the same here, and maybe call them highlightColor1/highlightColor2/highlightColor3/highlightColor4?

@uncenter uncenter changed the title fix(chess.com): arrow color fix fix(chess.com): arrow and square highlights Mar 11, 2025
@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Mar 11, 2025
@nuexq
Copy link
Member Author

nuexq commented Mar 12, 2025

The color swaps between Shift + Right Click and Right Click in the original theme is due to a bug on Chess.com. This issue causes the red and peach square be reversed compared to how it should look based on it's arrow. I will let as it is so if the bug fixed nothing break.

original theme:
image

@nuexq nuexq removed the waiting on author Note for staff that a re-review is not yet required label Mar 12, 2025
@uncenter uncenter merged commit 41919d4 into catppuccin:main Mar 24, 2025
2 checks passed
@nuexq nuexq deleted the chess branch March 24, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chess.com Chess.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chess.com arrow/square highlight colors are wrong
2 participants