Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinterest): variables and pin actions #1660

Merged
merged 7 commits into from
Mar 23, 2025
Merged

Conversation

nuexq
Copy link
Member

@nuexq nuexq commented Mar 14, 2025

🔧 What does this fix? 🔧

  • Fix hover state (--color-background-button-tertiary-hover):

    • Before:
      image
    • After:
      image
  • Fix opened state:

    • Before:
      image
    • After:
      image
  • Fix pin link background color:

    • Before:
      image
    • After:
      image
  • Fix issue caused by changing --color-text-dark (affecting one-bar-pill text color):

    • Before:
      image
    • After:
      image
  • Fixed similar issues on closeupActionBar for pins.

  • Addressed all possible cases for small white rectangles issue.


🗒 Checklist 🗒

Sorry, something went wrong.

@github-actions github-actions bot added the pinterest Pinterest label Mar 14, 2025
@nuexq nuexq requested a review from isabelroses March 14, 2025 15:06
@uncenter
Copy link
Member

fix hovering (--color-background-button-tertiary-hover):

Is the before and after for this one reversed? The first image looks better to me than the more transparent button in the second image.

@nuexq
Copy link
Member Author

nuexq commented Mar 14, 2025

Is the before and after for this one reversed? The first image looks better to me than the more transparent button in the second image.

yeah to me too but the original theme has it transparent not solid.

original theme:
image

@nuexq nuexq merged commit 7ca389f into catppuccin:main Mar 23, 2025
2 checks passed
@nuexq nuexq deleted the pinterest branch March 23, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinterest Pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants