Restrict access to /byemail routes #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivm
approved these changes
Mar 30, 2021
…o 140-restrict-byemail-routes
|
@martinbedouret This needs to be reviewed :-) |
sylvansson
force-pushed
the
140-restrict-byemail-routes
branch
from
dfb4ad0 to
9a91cf9
Compare
sylvansson
force-pushed
the
140-restrict-byemail-routes
branch
from
9a91cf9 to
3c4c310
Compare
sylvansson
force-pushed
the
140-restrict-byemail-routes
branch
from
a62ab95 to
e54565b
Compare
|
I'll merge now since this PR fixes the pipeline for master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
getCommunicatorsEmailandgetBoardsEmailroutes to return a 403 if a non-admin user sends the wrong email address. There are no restrictions for admins. This is the first step towards updating theCommunicatorandBoardschemas to identify the owner by their id rather than their email address. See #140.