-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix touch bug #1264
base: master
Are you sure you want to change the base?
Feature/fix touch bug #1264
Conversation
thanks @vlaco ! please link the issue that you are resolving.
and
|
@@ -192,33 +192,29 @@ export class Board extends Component { | |||
const variant = Boolean(tile.loadBoard) ? 'folder' : 'button'; | |||
|
|||
return ( | |||
<div key={tile.id}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key is necessary. See https://reactjs.org/docs/lists-and-keys.html
@martinbedouret this is an attempt to resolve this issue #1233 |
Hi! @vlaco and @matijavibe! Thanks for been part of these amazing project! |
I note the same as @RodriSanchez1 . When the users scroll the board tiles are pressed. Also, this PR eliminates the possibility of selecting tiles with the scanner feature and the feature of navigating fixed boards with the arrow keys is damaged too. |
In order to solve this a refactor of the whole app is needed |
The bug with multi touch was fixed by installing hammerjs library. Please test if everything is still working properly. An attempt to resolve #1233