Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix touch bug #1264

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

vlaco
Copy link

@vlaco vlaco commented Sep 23, 2022

The bug with multi touch was fixed by installing hammerjs library. Please test if everything is still working properly. An attempt to resolve #1233

@martinbedouret
Copy link
Collaborator

@vlaco Thanks for this. Is there an open issue with the bug?
Please remove lock files from the PR.
@tomivm Could you please do the review for this?

@tomivm
Copy link
Collaborator

tomivm commented Sep 29, 2022

thanks @vlaco ! please link the issue that you are resolving.
About the testing.
Tiles aren't rendered and I receive the following errors on the console:

Warning: Each child in a list should have a unique "key" prop.

Check the render method of `Board`. See https://reactjs.org/link/warning-keys for more information.

and

Warning: Failed prop type: Duplicate child key "null" found! This will cause problems in ReactGridLayout.

@@ -192,33 +192,29 @@ export class Board extends Component {
const variant = Boolean(tile.loadBoard) ? 'folder' : 'button';

return (
<div key={tile.id}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlaco
Copy link
Author

vlaco commented Oct 3, 2022

@vlaco Thanks for this. Is there an open issue with the bug? Please remove lock files from the PR. @tomivm Could you please do the review for this?

@martinbedouret this is an attempt to resolve this issue #1233

@RodriSanchez1
Copy link
Collaborator

RodriSanchez1 commented Oct 6, 2022

Hi! @vlaco and @matijavibe! Thanks for been part of these amazing project!
I just tested in web and android device. When you try to scroll the board view in touch devices the tapped tile is pressed. You will need to treat the pan event.

@tomivm
Copy link
Collaborator

tomivm commented Oct 6, 2022

I note the same as @RodriSanchez1 . When the users scroll the board tiles are pressed. Also, this PR eliminates the possibility of selecting tiles with the scanner feature and the feature of navigating fixed boards with the arrow keys is damaged too.

@vlaco
Copy link
Author

vlaco commented Jun 1, 2023

In order to solve this a refactor of the whole app is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tile is not pressed if user hold tap
4 participants