Adding Drag and Drop Functionality for Symbol Tiles in Output Bar (Issue #890) #1303
+41,912
−13,567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomivm can you please take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this fork we added drag and drop functionality for symbol tiles loaded into the output file as a response to the open issue feature request with id #890 . When the user holds the mouse down on one of the tiles in the output bar, the tile becomes slightly transparent and begins to move with the user’s mouse while they continue to hold the mouse down. If the user drags the tile and drops it past the middle point of the width of another tile, it will adjust the order to put the moved tile in a new spot, shifting the other tiles in one direction to accommodate the new order. Users are able to drag and drop tiles in both directions to be able to easily correct any mistakes made during their initial selection, rather than needing to delete the entire incorrect portion and rebuild it. In order to increase our confidence that our alterations worked as expected, we found individuals who had not worked on the code with us and asked them to try out the feature without any knowledge of how it worked internally to simulate how actual users would approach it and try to find any edge cases we may have missed.